On 10/28/22 19:30, Thierry Reding wrote: > On Fri, Oct 28, 2022 at 12:07:38PM +0100, Jon Hunter wrote: >> On 28/10/2022 10:25, Jon Hunter wrote: >>> On 28/10/2022 03:19, Krzysztof Kozlowski wrote: >>>> On 25/10/2022 04:02, Wayne Chang wrote: >>>>>>> + power-domain-names: >>>>>>> + items: >>>>>>> + - const: xusb_host >>>>>>> + - const: xusb_ss >>>>>> Drop 'xusb_'. >>>>> The properties are constant and we use the name to get the power domain. >>>>> >>>>> tegra->genpd_dev_host = dev_pm_domain_attach_by_name(dev, >>>>> "xusb_host"); >>>>> >>>>> tegra->genpd_dev_ss = dev_pm_domain_attach_by_name(dev, "xusb_ss"); >>>>> >>>>> we might not be able to drop the xusb_ >>>> These are new bindings, so why do say they are "constant"? New bindings >>>> means you did not use them. If you used them before bindings... what can >>>> we say? Don't? >>> Not exactly. However, what we should do here is convert the legacy >>> binding doc [0] and replace with this one. But yes we are stuck with the >>> 'xusb_host' naming. >> >> Thierry already has a patch to do this [0]. So we should fix that up and >> included in this series. >> >> Jon >> >> [0]https://lore.kernel.org/linux-tegra/20211209165339.614498-3-thierry.reding@xxxxxxxxx/ > I have a v2 with at least some of the comments addressed. I'll go > through them again and send it out. If we can get that reviewed, it can > be included in this series and the Tegra234 addition be applied on top. Thanks for the help, Thierry. I'll update the binding after your change got updated. > > Thierry thanks, Wayne.
