On Fri, Oct 28, 2022 at 05:36:41AM +0000, Jim Lin wrote: > On Thu, 2022-10-27 at 15:58 +0200, Greg KH wrote: > > External email: Use caution opening links or attachments > > > > > > On Thu, Oct 27, 2022 at 09:31:25PM +0800, Jim Lin wrote: > > > Add EXPORT_SYMBOL_GPL on xhci_hub_control() for other driver module > > > to invoke and avoid linking error. > > > > What other driver module? > > > > There is no user here :( > > > > confused, > > > > In arch/arm/configs/multi_v7_defconfig > It defines > CONFIG_USB_XHCI_TEGRA=m > > If I don't add EXPORT_SYMBOL_GPL on xhci_hub_control() > , I will get compile/linking error like > > ERROR: modpost: "xhci_hub_control" [drivers/usb/host/xhci-tegra.ko] > undefined! > > if patch > "[PATCH v5,3/3] xhci: tegra: USB2 pad power controls" > > https://patchwork.kernel.org/project/linux-usb/patch/20221027133127.27592-4-jilin@xxxxxxxxxx/ > is added in xhci-tegra.c to invoke xhci_hub_control() > > Should I integrate this patch with [PATCH v5,3/3] as one? Yes, do not add something that is not needed for that specific commit, otherwise it causes reviewers to be confused. thanks, greg k-h
