Hi Ulf, >> In that case, perhaps we can add a "depends on IOMMU_API" in the Kconfig >> instead? Or is the tegra driver used on platforms where IOMMU_API could be >> unset? Yes it can/will work with IOMMU disabled so its not recommended to add a "depends on" condition in Kconfig. Thanks Prathamesh > -----Original Message----- > From: Ulf Hansson <ulf.hansson@xxxxxxxxxx> > Sent: Tuesday, October 11, 2022 6:04 PM > To: Prathamesh Shete <pshete@xxxxxxxxxx> > Cc: adrian.hunter@xxxxxxxxx; thierry.reding@xxxxxxxxx; Jonathan Hunter > <jonathanh@xxxxxxxxxx>; p.zabel@xxxxxxxxxxxxxx; linux- > mmc@xxxxxxxxxxxxxxx; linux-tegra@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; Aniruddha Tvs Rao <anrao@xxxxxxxxxx>; Suresh > Mangipudi <smangipudi@xxxxxxxxxx>; Krishna Yarlagadda > <kyarlagadda@xxxxxxxxxx> > Subject: Re: [PATCH v7 2/4] mmc: sdhci-tegra: Add support to program MC > stream ID > > External email: Use caution opening links or attachments > > > On Tue, 11 Oct 2022 at 13:44, Prathamesh Shete <pshete@xxxxxxxxxx> wrote: > > > > Hi Ulf > > > > The initial patches were without the #ifdef. #ifdef is being added as per review > comments and kernel robot errors. > > Following error was detected by kernel robot > > >> > > All errors (new ones prefixed by >>): > > > > drivers/mmc/host/sdhci-tegra.c: In function 'sdhci_tegra_probe': > > >> drivers/mmc/host/sdhci-tegra.c:1794:54: error: 'struct iommu_fwspec' has > no member named 'ids' > > 1794 | tegra_host->streamid = fwspec->ids[0] & 0xffff; > > | ^~ > > > > > > vim +1794 drivers/mmc/host/sdhci-tegra.c > > >> > > Adrian also pointed out this issue so to address these issues #ifdef > > was added > > I see! > > In that case, perhaps we can add a "depends on IOMMU_API" in the Kconfig > instead? Or is the tegra driver used on platforms where IOMMU_API could be > unset? > > [...] > > Kind regards > Uffe
