On Tue, Oct 11, 2022 at 3:02 AM Kent Gibson <warthog618@xxxxxxxxx> wrote:
> On Mon, Oct 10, 2022 at 11:14:18PM +0300, Andy Shevchenko wrote:
...
> > -#include <linux/gpio.h>
> > #include <linux/gpio/driver.h>
> > +#include <linux/gpio.h>
> > +#include <linux/hte.h>
>
> Ok with the hte re-order.
>
> But moving the gpio subsystem header after the gpio/driver is not
> alphabetical ('.' precedes '/') and it read better and made more sense
> to me the way it was.
I see, I guess this is vim sort vs shell sort. Strange, they should
follow the locale settings...
...
> > +#include <linux/seq_file.h>
>
> I wasn't aware that we use anything from seq_file.
> What am I missing?
I will recheck, because in v6.0 I don't see anything, but LKP was not
okay with something IIRC.
--
With Best Regards,
Andy Shevchenko
