On 09/10/2022 09:18, Uwe Kleine-König wrote:
Hello, On Fri, Oct 07, 2022 at 09:45:24AM +0100, Jon Hunter wrote:Commit 8c193f4714df ("pwm: tegra: Optimize period calculation") updated the period calculation in the Tegra PWM driver and now returns an error if the period requested is less than minimum period supported. This is breaking PWM support on various Tegra platforms. For example, on the Tegra210 Jetson Nano platform this is breaking the PWM fan support and probing the PWM fan driver now fails ... pwm-fan pwm-fan: Failed to configure PWM: -22 pwm-fan: probe of pwm-fan failed with error -22 The problem is that the default parent clock for the PWM on Tegra210 is a 32kHz clock and is unable to support the requested PWM period. Fix PWM support on Tegra20, Tegra30, Tegra124 and Tegra210 by updating the parent clock for the PWM to be the PLL_P. Fixes: 8c193f4714df ("pwm: tegra: Optimize period calculation") Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx>First of all, thanks for your fix. Very appreciated.
No problem.
Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Thanks. I have just sent a V3 because I was missing a fix for Tegra114. Can you ACK that one as well?
Who will take care for this patch? I assume it will be Stephen and Michael (i.e. the clk maintainers)? Do you consider this patch fine for application before the next merge window, or do you expect that it might break other use cases and so should cook in next for some time?
We should pick this up as a fix for v6.1. I also plan to request this is pulled into stable as well (all going well).
Cheers Jon -- nvpublic
