On 29/09/2022 19:04, Diogo Ivo wrote: > The LPM102A188A is a 10.2" 2560x1800 IPS panel found in > the Google Pixel C. > Thank you for your patch. There is something to discuss/improve. > + Each of the DSI channels controls a separate DSI peripheral. The peripheral > + driven by the first link (DSI-LINK1) is considered the primary peripheral > + and controls the device. The 'link2' property contains a phandle to the > + peripheral driven by the second link (DSI-LINK2). > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: jdi,lpm102a188a > + > + reg: true > + enable-gpios: true > + reset-gpios: true > + power-supply: true > + backlight: true > + > + ts-reset-gpios: > + maxItems: 1 > + description: | > + Specifier for a GPIO connected to the touchscreen reset control signal. > + The reset signal is active low. Isn't touchscreen a separate (input) device? > + > + ddi-supply: > + description: The regulator that provides IOVCC (1.8V). > + > + link2: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: | > + phandle to the DSI peripheral on the secondary link. Note that the > + presence of this property marks the containing node as DSI-LINK1. Best regards, Krzysztof
