Hi Jonathan,
Thanks for the review.
On 9/29/22 03:04, Jonathan Hunter wrote:
>
> On 28/09/2022 14:55, Wayne Chang wrote:
>> From: Sing-Han Chen <singhanc@xxxxxxxxxx>
>>
>> This commit adds XUSB device mode controller support on Tegra234 SoC.
>> Tegra234 XUDC is very similar to the existing Tegra194 XUDC.
>>
>> Signed-off-by: Sing-Han Chen <singhanc@xxxxxxxxxx>
>> Signed-off-by: Wayne Chang <waynec@xxxxxxxxxx>
>> ---
>> drivers/usb/gadget/udc/tegra-xudc.c | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c
>> index 3c37effdfa64..53277aa5a270 100644
>> --- a/drivers/usb/gadget/udc/tegra-xudc.c
>> +++ b/drivers/usb/gadget/udc/tegra-xudc.c
>> @@ -3656,6 +3656,19 @@ static struct tegra_xudc_soc tegra194_xudc_soc_data = {
>> .has_ipfs = false,
>> };
>>
>> +static struct tegra_xudc_soc tegra234_xudc_soc_data = {
>> + .clock_names = tegra186_xudc_clock_names,
>> + .num_clks = ARRAY_SIZE(tegra186_xudc_clock_names),
>> + .num_phys = 4,
>> + .u1_enable = true,
>> + .u2_enable = true,
>> + .lpm_enable = true,
>> + .invalid_seq_num = false,
>> + .pls_quirk = false,
>> + .port_reset_quirk = false,
>> + .has_ipfs = false,
>> +};
>> +
>> static const struct of_device_id tegra_xudc_of_match[] = {
>> {
>> .compatible = "nvidia,tegra210-xudc",
>> @@ -3669,6 +3682,10 @@ static const struct of_device_id tegra_xudc_of_match[] = {
>> .compatible = "nvidia,tegra194-xudc",
>> .data = &tegra194_xudc_soc_data
>> },
>> + {
>> + .compatible = "nvidia,tegra234-xudc",
>> + .data = &tegra234_xudc_soc_data
>> + },
>
>
> The device-tree binding documentation is missing for this compatible
> string. Please send a patch to add this compatible string to the
> appropriate binding doc.
Thanks. Sent out the change to add the compatible string to xudc binding
doc.
https://lore.kernel.org/all/20220929034221.3817058-1-waynec@xxxxxxxxxx/T/#u
>
> Thanks!
> Jon
>
thanks,
Wayne.
