+Russell, Andrew, Vladimir, On 9/23/22 04:49, Thierry Reding wrote:
From: Bhadram Varka <vbhadram@xxxxxxxxxx> Add support for the Multi-Gigabit Ethernet (MGBE/XPCS) IP found on NVIDIA Tegra234 SoCs. Signed-off-by: Bhadram Varka <vbhadram@xxxxxxxxxx> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> --- drivers/net/ethernet/stmicro/stmmac/Kconfig | 6 + drivers/net/ethernet/stmicro/stmmac/Makefile | 1 + .../net/ethernet/stmicro/stmmac/dwmac-tegra.c | 290 ++++++++++++++++++
You should be modeling this as a proper PCS driver and have a 'pcs-handle' property pointing to it in your Device Tree.
The configuration you are doing here is probably working the first time you bring-up the network device but I doubt it works across system suspend/resume states where power to the GMAC and PCS is lost, it also begs the question of which mediums this was tested with and whether dynamic switching of speeds and so on is working?
-- Florian
