On Mon, Sep 26, 2022 at 02:23:05PM +0200, Joerg Roedel wrote: > External email: Use caution opening links or attachments > > > Hi Nicolin, > > On Fri, Sep 23, 2022 at 12:16:29AM -0700, Nicolin Chen wrote: > > This series is to replace the previous EMEDIUMTYPE patch in a VFIO series: > > https://lore.kernel.org/kvm/Yxnt9uQTmbqul5lf@xxxxxxxxxx/ > > \o/ > > > Nicolin Chen (5): > > iommu/amd: Drop unnecessary checks in amd_iommu_attach_device() > > iommu: Add return value rules to attach_dev op and APIs > > iommu: Regulate EINVAL in ->attach_dev callback functions > > iommu: Use EINVAL for incompatible device/domain in ->attach_dev > > iommu: Propagate return value in ->attach_dev callback functions > > This looks good to me, but I'd like to have the SMMU people have a look > at patch 4. And I think it is too late for this to make it into 6.1, so > please re-send after 6.1-rc1 is out. Robin has given review comments against the similar patch in the EMEDIUMTYPE series, though it'd be nicer to have a Reviewed-by. I will re-send them rebasing on v6.1rc1. Thanks! Nic
