On 22/09/2022 16:33, Liu Shixin wrote:
> Use DEFINE_SHOW_ATTRIBUTE helper macro to simplify the code.
> No functional change.
>
> Signed-off-by: Liu Shixin <liushixin2@xxxxxxxxxx>
> ---
> drivers/memory/tegra/tegra210-emc-core.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/memory/tegra/tegra210-emc-core.c b/drivers/memory/tegra/tegra210-emc-core.c
> index cbe1a7723514..603b306daca1 100644
> --- a/drivers/memory/tegra/tegra210-emc-core.c
> +++ b/drivers/memory/tegra/tegra210-emc-core.c
> @@ -1621,20 +1621,8 @@ static int tegra210_emc_debug_available_rates_show(struct seq_file *s,
>
> return 0;
> }
> +DEFINE_SHOW_ATTRIBUTE(tegra210_emc_debug_available_rates);
>
> -static int tegra210_emc_debug_available_rates_open(struct inode *inode,
> - struct file *file)
> -{
> - return single_open(file, tegra210_emc_debug_available_rates_show,
> - inode->i_private);
> -}
> -
> -static const struct file_operations tegra210_emc_debug_available_rates_fops = {
> - .open = tegra210_emc_debug_available_rates_open,
> - .read = seq_read,
> - .llseek = seq_lseek,
> - .release = single_release,
> -};
>
It looks you leave here two blank lines. If so, please fix it - only one
blank line.
> static int tegra210_emc_debug_min_rate_get(void *data, u64 *rate)
> {
Best regards,
Krzysztof
