> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Thursday, September 8, 2022 5:44 PM > To: Sandipan Patra <spatra@xxxxxxxxxx>; thierry.reding@xxxxxxxxx; > Jonathan Hunter <jonathanh@xxxxxxxxxx>; robh+dt@xxxxxxxxxx; > krzysztof.kozlowski+dt@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > tegra@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Cc: Bibek Basu <bbasu@xxxxxxxxxx>; Krishna Yarlagadda > <kyarlagadda@xxxxxxxxxx> > Subject: Re: [PATCH 1/3] dt-bindings: pwm: tegra: Add compatible string for > Tegra234 > > External email: Use caution opening links or attachments > > > On 07/09/2022 08:25, Sandipan Patra wrote: > > Tegra234 has 8 different PWM controllers and each controller has only > > one output. Add a device tree compatible string for Tegra234. > > > > Signed-off-by: Sandipan Patra <spatra@xxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > a/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt > > b/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt > > index 74c41e34c3b6..331c1e66e8fa 100644 > > --- a/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt > > +++ b/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt > > @@ -9,7 +9,7 @@ Required properties: > > - "nvidia,tegra132-pwm", "nvidia,tegra20-pwm": for Tegra132 > > - "nvidia,tegra210-pwm", "nvidia,tegra20-pwm": for Tegra210 > > - "nvidia,tegra186-pwm": for Tegra186 > > - - "nvidia,tegra194-pwm": for Tegra194 > > + - "nvidia,tegra194-pwm": for Tegra194, Tegra234 > > The commit msg suggest it is different. Are you sure they are exactly the > same? If not the same, but compatible, you should use fallback. Tegra194 and Tegra234 are 2 different chips using exactly same pwm module and dt node. This change is to convey that same compatible is used for Tegra234 as well. Thanks & Regards, Sandipan > > Best regards, > Krzysztof
