On Mon, Sep 5, 2022 at 9:33 AM Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
>
> I would like to stop exporting OF-specific devm_gpiod_get_from_of_node()
> so that gpiolib can be cleaned a bit, so let's switch to the generic
> fwnode property API.
Special thanks for using dev_fwnode().
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
(Dunno if my suggestion about parent applies here)
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
>
> diff --git a/drivers/regulator/bd71815-regulator.c b/drivers/regulator/bd71815-regulator.c
> index acaa6607898e..c2b8b8be7824 100644
> --- a/drivers/regulator/bd71815-regulator.c
> +++ b/drivers/regulator/bd71815-regulator.c
> @@ -571,11 +571,10 @@ static int bd7181x_probe(struct platform_device *pdev)
> dev_err(&pdev->dev, "No parent regmap\n");
> return -ENODEV;
> }
> - ldo4_en = devm_gpiod_get_from_of_node(&pdev->dev,
> - pdev->dev.parent->of_node,
> - "rohm,vsel-gpios", 0,
> - GPIOD_ASIS, "ldo4-en");
>
> + ldo4_en = devm_fwnode_gpiod_get(&pdev->dev,
> + dev_fwnode(pdev->dev.parent),
> + "rohm,vsel", GPIOD_ASIS, "ldo4-en");
> if (IS_ERR(ldo4_en)) {
> ret = PTR_ERR(ldo4_en);
> if (ret != -ENOENT)
>
> --
> b4 0.10.0-dev-fc921
--
With Best Regards,
Andy Shevchenko
