On Wed, Jul 27, 2022 at 06:53:14PM +0800, Jim Lin wrote: > Program USB2 pad PD controls during port > connect/disconnect, port suspend/resume etc > as suggested by HW to reduce power consumption. You do have a full 72 columns to use :) And this does not explain what this commit does at all, or why we would want to take it. Please read the kernel documentation for how to write a good changelog commit. > Squash following fixes from local kernel 4.9 to this commit: > ce4e7e5 usb: host: tegra: Power on utmi pads > 3a10c61 usb: tegra: Program USB2 pad PD controls > 4e62fbb xhci: tegra: move pad power on to non-atomic place > ed0fb0a usb: xhci: tegra: don't use hs_pls in xhci-iov > 401801a usb: xhci: add USB2 pad PD control for Test Mode This makes no sense, as these commits are not in our kernel tree at all. Also they are not even in the correct format, if we were to take them (hint, you need to fix your development process to not take lines like this.) > > Signed-off-by: Allie Liu <alliel@xxxxxxxxxx> > Signed-off-by: Jim Lin <jilin@xxxxxxxxxx> > --- > drivers/phy/tegra/xusb-tegra186.c | 27 +++-- > drivers/phy/tegra/xusb.c | 32 +++++- > drivers/phy/tegra/xusb.h | 4 +- > drivers/usb/gadget/udc/tegra-xudc.c | 8 +- > drivers/usb/host/xhci-hub.c | 2 + > drivers/usb/host/xhci-tegra.c | 146 +++++++++++++++++++++++++++- > include/linux/phy/tegra/xusb.h | 4 +- > 7 files changed, 209 insertions(+), 14 deletions(-) Are you sure you want to touch all of these files in a single commit? Why not submit a patch series? thanks, greg k-h
