On 7/7/22 20:30, Robin Murphy wrote:
Conditional registration is a problem for other subsystems which may unwittingly try to interact with host1x_context_device_bus_type in an uninitialised state on non-Tegra platforms. A look under /sys/bus on a typical system already reveals plenty of entries from enabled but otherwise irrelevant configs, so lets keep things simple and register our context bus unconditionally too. Signed-off-by: Robin Murphy <robin.murphy@xxxxxxx> --- drivers/gpu/host1x/context_bus.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/host1x/context_bus.c b/drivers/gpu/host1x/context_bus.c index b0d35b2bbe89..d9421179d7b4 100644 --- a/drivers/gpu/host1x/context_bus.c +++ b/drivers/gpu/host1x/context_bus.c @@ -15,11 +15,6 @@ static int __init host1x_context_device_bus_init(void) { int err;- if (!of_machine_is_compatible("nvidia,tegra186") &&- !of_machine_is_compatible("nvidia,tegra194") && - !of_machine_is_compatible("nvidia,tegra234")) - return 0; - err = bus_register(&host1x_context_device_bus_type); if (err < 0) { pr_err("bus type registration failed: %d\n", err);
Reviewed-by: Mikko Perttunen <mperttunen@xxxxxxxxxx> Cheers, Mikko
