On 06/07/2022 05:12, Bhadram Varka wrote: > Add device-tree binding documentation for the Tegra234 MGBE ethernet > controller. > > Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx> > Signed-off-by: Bhadram Varka <vbhadram@xxxxxxxxxx> > --- > .../bindings/net/nvidia,tegra234-mgbe.yaml | 167 ++++++++++++++++++ > 1 file changed, 167 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/nvidia,tegra234-mgbe.yaml > > diff --git a/Documentation/devicetree/bindings/net/nvidia,tegra234-mgbe.yaml b/Documentation/devicetree/bindings/net/nvidia,tegra234-mgbe.yaml > new file mode 100644 > index 000000000000..1a45cd374b19 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/nvidia,tegra234-mgbe.yaml > @@ -0,0 +1,167 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/nvidia,tegra234-mgbe.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tegra234 MGBE Device Tree Bindings Either you agree with a comment/feedback or you answer and we keep discussion going. Ignoring a comment is a no-go. Please fix everything what Rob pointed out. > + > +maintainers: > + - Thierry Reding <treding@xxxxxxxxxx> > + - Jon Hunter <jonathanh@xxxxxxxxxx> > + > +properties: > + > + compatible: > + const: nvidia,tegra234-mgbe > + > + reg: > + minItems: 3 > + maxItems: 3 > + > + reg-names: > + items: > + - const: hypervisor > + - const: mac > + - const: xpcs > + > + interrupts: > + minItems: 1 > + > + interrupt-names: > + items: > + - const: common NAK. Best regards, Krzysztof
