On Fri, Jun 24, 2022 at 11:26 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Tue, 21 Jun 2022 18:10:14 +0300, Mikko Perttunen wrote: > > From: Thierry Reding <treding@xxxxxxxxxx> > > > > Convert the Tegra host1x controller bindings from the free-form text > > format to json-schema. > > > > This also adds the missing display-hub DT bindings that were not > > previously documented. > > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> > > --- > > .../display/tegra/nvidia,tegra114-mipi.txt | 41 -- > > .../display/tegra/nvidia,tegra114-mipi.yaml | 74 ++ > > .../display/tegra/nvidia,tegra124-dpaux.yaml | 149 ++++ > > .../display/tegra/nvidia,tegra124-sor.yaml | 206 ++++++ > > .../display/tegra/nvidia,tegra124-vic.yaml | 71 ++ > > .../display/tegra/nvidia,tegra186-dc.yaml | 85 +++ > > .../tegra/nvidia,tegra186-display.yaml | 310 ++++++++ > > .../tegra/nvidia,tegra186-dsi-padctl.yaml | 45 ++ > > .../display/tegra/nvidia,tegra20-dc.yaml | 181 +++++ > > .../display/tegra/nvidia,tegra20-dsi.yaml | 159 +++++ > > .../display/tegra/nvidia,tegra20-epp.yaml | 70 ++ > > .../display/tegra/nvidia,tegra20-gr2d.yaml | 73 ++ > > .../display/tegra/nvidia,tegra20-gr3d.yaml | 214 ++++++ > > .../display/tegra/nvidia,tegra20-hdmi.yaml | 126 ++++ > > .../display/tegra/nvidia,tegra20-host1x.txt | 675 ------------------ > > .../display/tegra/nvidia,tegra20-host1x.yaml | 347 +++++++++ > > .../display/tegra/nvidia,tegra20-isp.yaml | 67 ++ > > .../display/tegra/nvidia,tegra20-mpe.yaml | 73 ++ > > .../display/tegra/nvidia,tegra20-tvo.yaml | 58 ++ > > .../display/tegra/nvidia,tegra20-vi.yaml | 163 +++++ > > .../display/tegra/nvidia,tegra210-csi.yaml | 52 ++ > > .../pinctrl/nvidia,tegra124-dpaux-padctl.txt | 59 -- > > 22 files changed, 2523 insertions(+), 775 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.txt > > create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml > > create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra124-dpaux.yaml > > create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra124-sor.yaml > > create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra124-vic.yaml > > create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra186-dc.yaml > > create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra186-display.yaml > > create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra186-dsi-padctl.yaml > > create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-dc.yaml > > create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-dsi.yaml > > create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-epp.yaml > > create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-gr2d.yaml > > create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-gr3d.yaml > > create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml > > delete mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt > > create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml > > create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-isp.yaml > > create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-mpe.yaml > > create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-tvo.yaml > > create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml > > create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra210-csi.yaml > > delete mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-dpaux-padctl.txt > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/tegra/nvidia,tegra124-sor.yaml: allOf:1:if:not:properties: {'contains': {'const': 'nvidia,panel'}} should not be valid under {'$ref': '#/definitions/sub-schemas'} > hint: A json-schema keyword was found instead of a DT property name. > from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/tegra/nvidia,tegra124-sor.yaml: ignoring, error in schema: allOf: 1: if: not: properties > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-gr3d.example.dtb: gr3d@54180000: resets: [[4294967295, 24]] is too short > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-gr3d.yaml > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-gr3d.example.dtb: gr3d@54180000: reset-names: ['3d'] is too short > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-gr3d.yaml > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.example.dtb: gr2d@54140000: resets: [[4294967295, 21]] is too short > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-gr2d.yaml > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.example.dtb: gr2d@54140000: reset-names: ['2d'] is too short > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-gr2d.yaml > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.example.dtb: gr3d@54180000: resets: [[4294967295, 24]] is too short > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-gr3d.yaml > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.example.dtb: gr3d@54180000: reset-names: ['3d'] is too short > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-gr3d.yaml > Documentation/devicetree/bindings/display/tegra/nvidia,tegra124-sor.example.dtb:0:0: /example-0/sor@54540000: failed to match any schema with compatible: ['nvidia,tegra210-sor'] > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-gr2d.example.dtb: gr2d@54140000: resets: [[4294967295, 21]] is too short > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-gr2d.yaml > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-gr2d.example.dtb: gr2d@54140000: reset-names: ['2d'] is too short > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-gr2d.yaml > > doc reference errors (make refcheckdocs): > MAINTAINERS: Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt > MAINTAINERS: Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt > > See https://patchwork.ozlabs.org/patch/ > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. Now failing in linux-next. Please fix. Rob