On Fri, Jun 10, 2022 at 01:03:08PM +0100, Mark Brown wrote: > On Thu, Jun 09, 2022 at 09:03:15PM -0500, Samuel Holland wrote: > > On 6/9/22 8:32 AM, Mark Brown wrote: > > > On Thu, 19 May 2022 16:42:22 +0100, Charles Keepax wrote: > > Please delete unneeded context from mails when replying. Doing this > makes it much easier to find your reply in the message, helping ensure > it won't be missed by people scrolling through the irrelevant quoted > material. > > > > [22/56] ASoC: sunxi: Update to use set_fmt_new callback > > > commit: 7cc3965fde74c9c725ed01de4ac35bc7d562d16a > > > This patch is wrong, which I pointed out earlier[1]. It will break audio on the > > Allwinner A33 and A64 SoCs. Charles said he would send a v2[2]. Excluding the > > changes to sound/soc/sunxi/sun8i-codec.c from the patch would fix it. > > Your mail doesn't say that this will break, it says the change is > unexpected. In any case, please send an incremental fix - there's no > need to revert the entire series for this. Apologies guys was on PTO last week, I will send an incremental fix today to patch up the issues. Thanks, Charles
