Hi Geert, Thank you for the review. On Thu, May 19, 2022 at 1:01 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > On Wed, May 18, 2022 at 9:30 PM Lad Prabhakar > <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote: > > Document the required properties to handle GPIO IRQ. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml > > +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml > > @@ -126,6 +139,9 @@ examples: > > gpio-controller; > > #gpio-cells = <2>; > > gpio-ranges = <&pinctrl 0 0 392>; > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + interrupt-parent = <&irqc>; > > I think the "interrupt-parent" property can be dropped from the example. > Sure will drop it in the next version. Cheers, Prabhakar > > clocks = <&cpg CPG_MOD R9A07G044_GPIO_HCLK>; > > resets = <&cpg R9A07G044_GPIO_RSTN>, > > <&cpg R9A07G044_GPIO_PORT_RESETN>, > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds