Thank you Andy. Pushed V3 patch addressing recent comments. Please help to review. Thanks & Regards, Sandipan > -----Original Message----- > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Sent: Friday, April 1, 2022 7:14 PM > To: Sandipan Patra <spatra@xxxxxxxxxx> > Cc: Thierry Reding <treding@xxxxxxxxxx>; Jonathan Hunter > <jonathanh@xxxxxxxxxx>; digetx@xxxxxxxxx; ulf.hansson@xxxxxxxxxx; > cai.huoqing@xxxxxxxxx; Bibek Basu <bbasu@xxxxxxxxxx>; linux- > tegra@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [Patch V2] soc/tegra: pmc: update Tegra234 reset sources > > External email: Use caution opening links or attachments > > > On Fri, Apr 01, 2022 at 04:19:35PM +0530, Sandipan Patra wrote: > > Reset_sources list is updated to add all reset sources and removing > > ones that do not actually exist. > > ... > > > + NULL, /* 0x10 */ > > I would suggest to add the comments more often, like every 8 entries. > > ... > > > + "FSI_VMON" /* 0x25 */ > > It would be good to have comma here as if this ever getting expanded the > additional churn may be avoided. > > > }; > > -- > With Best Regards, > Andy Shevchenko >
