> -----Original Message----- > From: Mark Brown <broonie@xxxxxxxxxx> > Sent: 23 February 2022 00:12 > To: Krishna Yarlagadda <kyarlagadda@xxxxxxxxxx> > Cc: thierry.reding@xxxxxxxxx; Jonathan Hunter > <jonathanh@xxxxxxxxxx>; linux-spi@xxxxxxxxxxxxxxx; linux- > tegra@xxxxxxxxxxxxxxx; Sowjanya Komatineni > <skomatineni@xxxxxxxxxx>; Laxman Dewangan > <ldewangan@xxxxxxxxxx>; robh+dt@xxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > p.zabel@xxxxxxxxxxxxxx > Subject: Re: [PATCH v2 5/5] spi: tegra210-quad: combined sequence > mode > > On Tue, Feb 22, 2022 at 11:26:11PM +0530, Krishna Yarlagadda wrote: > > > + val = tegra_qspi_readl(tqspi, QSPI_GLOBAL_CONFIG); > > + val |= QSPI_CMB_SEQ_EN; > > + tegra_qspi_writel(tqspi, val, QSPI_GLOBAL_CONFIG); > > I notice that nothing seems to clear QSPI_CMB_SEQ_EN - is that self > clearing or something? Need a change in non-combined sequence code to reset this. Will add the change in v3
