On Fri, Jan 21, 2022 at 11:18 AM Akhil R <akhilrajeev@xxxxxxxxxx> wrote: ... > > > +int device_irq_get_byname(struct device *dev, const char *name); > > > > Since we don't have device_irq_get() perhaps we don't need this one right now > > (just open code it in the caller). This will satisfy Rafael's request. > > If to code the same in caller, I guess, it would look like this - > irq = fwnode_irq_get_byname(dev_fwnode(adapter->dev.parent), > "smbus_alert"); Yep, I meant how you point to it in the documentation, e.g. The user may call fwnode_irq_get_byname() with the firmware node and name of the IRQ it wants to retrieve. > Looks okay to me, but if given an option I would go with device_irq_get_byname(). You see, there was a query from Rafael and I haven't seen an answer yet. On top there is no such function for fwnode_irq_get() (I mean device_irq_get() API). It would be harder to push without good justification why one has the device_ counterpart and the other does not. Easiest way, as I see it, is to drop it for now. -- With Best Regards, Andy Shevchenko
