Re: [PATCH] usb: common: ulpi: Fix crash in ulpi_match()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Heikki,

On 17/01/2022 14:10, Heikki Krogerus wrote:
Hi Jon,

On Fri, Jan 14, 2022 at 10:02:17AM +0000, Jon Hunter wrote:
Commit 7495af930835 ("ARM: multi_v7_defconfig: Enable drivers for
DragonBoard 410c") enables the CONFIG_PHY_QCOM_USB_HS for the ARM
multi_v7_defconfig. Enabling this Kconfig is causing the kernel to crash
on the Tegra20 Ventana platform in the ulpi_match() function.

The Qualcomm USB HS PHY driver that is enabled by CONFIG_PHY_QCOM_USB_HS,
registers a ulpi_driver but this driver does not provide an 'id_table',
so when ulpi_match() is called on the Tegra20 Ventana platform, it
crashes when attempting to deference the id_table pointer which is not
valid. The Qualcomm USB HS PHY driver uses device-tree for matching the
ULPI driver with the device and so fix this crash by using device-tree
for matching if the id_table is not valid.

Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx>

So is this fixing commit 7495af930835, or perhaps commit ef6a7bcfb01c
("usb: ulpi: Support device discovery via DT")?

I would assume ef6a7bcfb01c ("usb: ulpi: Support device discovery via
DT"). Please include the appropriate Fixes tag.


Yes that does sound appropriate. I have added and sent an update.

Cheers
Jon

--
nvpublic



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux