> On Thu, Dec 16, 2021 at 3:14 PM Akhil R <akhilrajeev@xxxxxxxxxx> wrote:
> >
> > Get interrupt by name from ACPI table as well.
>
> the interrupt resource
>
> > Add option to use 'interrupt-names' in _DSD which can map to interrupt
> > by index. The implementation is similar to 'interrupt-names' in devicetree.
> > Also add a common routine to get irq by name from devicetree and ACPI
> > table.
> >
> > Signed-off-by: Akhil R <akhilrajeev@xxxxxxxxxx>
> > ---
> > drivers/base/property.c | 35 +++++++++++++++++++++++++++++++++++
> > include/linux/property.h | 3 +++
> > 2 files changed, 38 insertions(+)
> >
> > diff --git a/drivers/base/property.c b/drivers/base/property.c index
> > cbe4fa2..7acf4fc 100644
> > --- a/drivers/base/property.c
> > +++ b/drivers/base/property.c
> > @@ -920,6 +920,41 @@ int fwnode_irq_get(const struct fwnode_handle
> > *fwnode, unsigned int index) EXPORT_SYMBOL(fwnode_irq_get);
> >
> > /**
> > + * fwnode_irq_get_byname - Get IRQ from a fwnode using its name
> > + * @fwnode: Pointer to the firmware node
> > + * @index: IRQ name
> > + *
>
> Needs a description to explain how the name is described.
>
> > + * Returns Linux IRQ number on success, errno otherwise.
> > + */
> > +int fwnode_irq_get_byname(const struct fwnode_handle *fwnode, const
> > +char *name) {
> > + int index;
> > +
> > + if (unlikely(!name))
> > + return -EINVAL;
> > +
> > + index = fwnode_property_match_string(fwnode, "interrupt-names",
> name);
> > + if (index < 0)
> > + return index;
>
> This property ise needs to be described in the ACPI documentation:
> https://www.kernel.org/doc/html/latest/firmware-
> guide/acpi/enumeration.html
>
> Perhaps after the DMA section.
Do you mean to document the complete interrupt usage in ACPI
including getting interrupt by index or only the named interrupt part?
Also please share if anything on the discussion we had previously.
Thanks,
Akhil
