RE: [PATCH v2] i2c: tegra: use i2c_timings for bus clock freq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 09.12.2021 19:28, Akhil R пишет:
> > -     err = device_property_read_u32(i2c_dev->dev, "clock-frequency",
> > -                                    &i2c_dev->bus_clk_rate);
> > -     if (err)
> > -             i2c_dev->bus_clk_rate = I2C_MAX_STANDARD_MODE_FREQ;
> > +     i2c_parse_fw_timings(i2c_dev->dev, &i2c_dev->timings, true);
> 
> Was this patch tested at all? Apparently, it wasn't compile-tested.
Sorry, it got somehow missed as the build did not fail when prepared
the image for testing. Thanks for pointing this out.
Would fix and update.

> 
> drivers/i2c/busses/i2c-tegra.c: In function ‘tegra_i2c_parse_dt’:
> drivers/i2c/busses/i2c-tegra.c:1635:13: warning: unused variable ‘err’ [-
> Wunused-variable]
>  1635 |         int err;
> 
> BTW, MM, DRI and media mailing lists have nothing to do with this patch
Even I was wondering on this, but apparently those lists are shown if get_maintainer.pl
is run. Would remove the mailing lists going further.

Thanks,
Akhil




[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux