On Wed, Dec 08, 2021 at 07:09:37PM +0300, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 08.12.2021 11:47, Nicolin Chen пишет: > > static void tegra_smmu_attach_as(struct tegra_smmu *smmu, > > struct tegra_smmu_as *as, > > unsigned int swgroup) > > @@ -517,6 +646,12 @@ static void tegra_smmu_attach_as(struct tegra_smmu *smmu, > > dev_warn(smmu->dev, > > "overwriting group->as for swgroup: %s\n", swgrp->name); > > group->as = as; > > + > > + if (smmu->debugfs_mappings) > > + debugfs_create_file(group->swgrp->name, 0444, > > + smmu->debugfs_mappings, group, > > + &tegra_smmu_debugfs_mappings_fops); > > I noticed this in KMSG: > > tegra-mc 7000f000.memory-controller: overwriting group->as for swgroup: g2 > debugfs: File 'g2' in directory 'mappings' already present! > tegra-mc 7000f000.memory-controller: overwriting group->as for swgroup: g2 > debugfs: File 'g2' in directory 'mappings' already present > > Doesn't look okay, please fix. Thanks for testing and reporting! I will see and fix it along with your other comments.