01.12.2021 13:07, Michał Mirosław пишет: > On Wed, Dec 01, 2021 at 01:38:02AM +0300, Dmitry Osipenko wrote: >> From: Svyatoslav Ryhel <clamor95@xxxxxxxxx> > [...] >> + i2c2: i2c@7000c400 { >> + status = "okay"; >> + clock-frequency = <400000>; >> + }; > [...] > > Nit: You could now use the new controller handles directly - that would > avoid some indentation and duplication. Though I understand it is a lot > of tedious reformatting. I see that there are people who prefer to use labels everywhere. Historically Tegra device-trees never used handles for nodes. I think should be better to convert all DTs together to keep them consistent, which I was asking to do before, but nobody wanted to put effort into doing that. There are already quite a lot of DT changes scheduled for 5.17, perhaps better to defer the extra changes for 5.18. I will add it to my todo list, but if you're going to type the patches, then please either send them to me, or to ML, or create PR to grate kernel. At some point in the past we had this common DTSI using labels for handles, but I asked to keep the DTs consistent, so we don't have them now.