> -----Original Message----- > From: Mark Brown <broonie@xxxxxxxxxx> > Sent: 25 November 2021 18:29 > To: Krishna Yarlagadda <kyarlagadda@xxxxxxxxxx> > Cc: Laxman Dewangan <ldewangan@xxxxxxxxxx>; Thierry Reding > <thierry.reding@xxxxxxxxx>; Jonathan Hunter <jonathanh@xxxxxxxxxx>; > Sowjanya Komatineni <skomatineni@xxxxxxxxxx>; Philipp Zabel > <p.zabel@xxxxxxxxxxxxxx>; linux-tegra@xxxxxxxxxxxxxxx; linux- > spi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 2/2] spi: tegra210-quad: add acpi support > > On Thu, Nov 25, 2021 at 03:25:52PM +0530, Krishna Yarlagadda wrote: > > > +#ifdef CONFIG_ACPI > > + if (ACPI_FAILURE(acpi_evaluate_object(ACPI_HANDLE(tqspi->dev), > > + "_RST", NULL, NULL))) > > + dev_err(tqspi->dev, "failed to reset device\n"); #endif > > What happens when this runs on a DT system? For a DT system reset handle would be present and this code will not run -KY