26.11.2021 00:26, Rob Herring пишет: > On Thu, 25 Nov 2021 01:00:39 +0300, Dmitry Osipenko wrote: >> Convert NVIDIA Tegra20 I2S binding to schema. >> >> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx> >> --- >> .../bindings/sound/nvidia,tegra20-i2s.txt | 30 -------- >> .../bindings/sound/nvidia,tegra20-i2s.yaml | 71 +++++++++++++++++++ >> 2 files changed, 71 insertions(+), 30 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra20-i2s.txt >> create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra20-i2s.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/nvidia,tegra20-i2s.example.dt.yaml: i2s@70002800: 'clock-names' is a required property > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/nvidia,tegra20-i2s.yaml > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/1559387 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > Indeed, I missed to re-check the I2S binding after last minute changes. That's compelling reason to make v2. Then I'll also remove the now-unnecessary assigned-clocks property from the S/PDIF binding.
