回复: [PATCH] firmware: tegra: switch over to memdup_user()

[王擎 <wangqing@xxxxxxxx>]

>> --- a/drivers/firmware/tegra/bpmp-debugfs.c
>> +++ b/drivers/firmware/tegra/bpmp-debugfs.c
>> @@ -376,18 +376,11 @@ static ssize_t bpmp_debug_store(struct file *file, const char __user *buf,
>>        if (!filename)
>>                return -ENOENT;
>>  
>> -     databuf = kmalloc(count, GFP_KERNEL);
>> -     if (!databuf)
>> -             return -ENOMEM;
>> -
>> -     if (copy_from_user(databuf, buf, count)) {
>> -             err = -EFAULT;
>> -             goto free_ret;
>> -     }
>> +     databuf = memdup_user(buf, count);
>> +     if (IS_ERR(databuf))
>> +             return ERR_PTR(PTR_ERR(databuf));
>
>ERR_PTR() is too much here.
>
>Best Regards
>Michał Mirosław

Sorry about that, I have resent the patch, Please ignore this version.

Thanks,
Qing