On 01-09-21, 08:44, Dmitry Osipenko wrote: > 01.09.2021 07:41, Viresh Kumar пишет: > > On 31-08-21, 16:54, Dmitry Osipenko wrote: > >> Elements of the 'names' array are not changed by the code, constify them > >> for consistency. > >> > >> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx> > >> --- > >> drivers/opp/core.c | 6 +++--- > >> include/linux/pm_opp.h | 8 ++++---- > >> 2 files changed, 7 insertions(+), 7 deletions(-) > >> > >> diff --git a/drivers/opp/core.c b/drivers/opp/core.c > >> index 602e502d092e..d4e706a8b70d 100644 > >> --- a/drivers/opp/core.c > >> +++ b/drivers/opp/core.c > >> @@ -2359,12 +2359,12 @@ static void _opp_detach_genpd(struct opp_table *opp_table) > >> * "required-opps" are added in DT. > >> */ > >> struct opp_table *dev_pm_opp_attach_genpd(struct device *dev, > >> - const char **names, struct device ***virt_devs) > >> + const char * const *names, struct device ***virt_devs) > > > > I am sure there are issues around space around * here. Please run > > checkpatch with --strict option for your series. > > > > It is the other way around. This fixes the checkpatch warning and that's > what checkpatch wants. You may also grep the kernel to find that this is > the only variant used in practice. Heh, you are right. I somehow thought that * never has a space right after. -- viresh
