On Tue, Aug 24, 2021 at 01:40:02AM +0200, Michał Mirosław wrote: > On Sat, Aug 21, 2021 at 08:27:15PM +0300, Dmitry Osipenko wrote: > > 21.08.2021 01:41, Michał Mirosław пишет: > > > On Thu, Aug 19, 2021 at 01:19:15AM +0300, Dmitry Osipenko wrote: > > >> This series adds the most minimal EFI partition support for NVIDIA Tegra > > >> consumer devices, like Android tablets and game consoles, making theirs > > >> eMMC accessible out-of-the-box using downstream bootloader and mainline > > >> Linux kernel. eMMC now works on Acer A500 tablet and Ouya game console > > >> that are already well supported in mainline and internal storage is the > > >> only biggest thing left to support. > > > [...] > > > > > > Could we provide the GPT sector via DT? As I understand this is for > > > non-removable eMMC storage. It would remove the need for a cap bit and > > > hardcoded calculations instead just checking if DT node of the controller > > > contains a magic entry with a number. > > > > The same device model usually comes in different flavors that have a > > different eMMC unit and size. So no, it can't be hardcoded in DT. > > I see. I was thinking how to avoid of going the whole way and creating > another controller capability (since this is going to be core code) - > could this workaround be enabled just by a boolean DT property at > controller's node instead? Or do we expect non-DT platforms to be > similarly broken? Rewording my concern: I believe that this is platform's and not a controller's misfeature, so the controller driver feels like wrong place fix. That's why I'd prefer that the enable came from the DT and not from driver's code. Best Regards Michał Mirosław
