Re: [PATCH v4 2/3] mmc: block: Add mmc_bdev_to_card() helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



17.08.2021 07:37, Christoph Hellwig пишет:
> On Tue, Aug 17, 2021 at 04:36:42AM +0300, Dmitry Osipenko wrote:
>> +	if (bdev->bd_disk->major != MMC_BLOCK_MAJOR)
>> +		return NULL;
> 
> The major is a dangerous check as we have all kinds of ways to override
> it.  Please check the block device operations as they must be unique.
> 

Alright, thank you for the suggestion.



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux