On 6/27/21 4:36 AM, Linus Walleij wrote: > On Sat, Jun 26, 2021 at 1:48 AM Dipen Patel <dipenp@xxxxxxxxxx> wrote: > >> gpiolib-cdev is extended to support hardware clock type, this >> patch reflects that fact. >> >> Signed-off-by: Dipen Patel <dipenp@xxxxxxxxxx> > (...) >> case 'w': >> config.flags |= GPIO_V2_LINE_FLAG_EVENT_CLOCK_REALTIME; >> break; >> + case 't': >> + config.flags |= GPIO_V2_LINE_FLAG_EVENT_CLOCK_HARDWARE; >> + break; > After the checking of the command line options we need a small sanity > check so we don't try to enable both realtime and hardware clock > at the same time, we will only be able to request one of them. This will any way fail at gpiolib-cdev layer. Do we want to add it here as well? > > Yours, > Linus Walleij