On Mon, Jul 12, 2021 at 03:13:41AM +0300, Dmitry Osipenko wrote: > - err = iommu_device_sysfs_add(&smmu->iommu, dev, NULL, dev_name(dev)); > + err = iommu_device_sysfs_add(&smmu->iommu, dev, NULL, "smmu"); Are you sure no one is relying on the old name so that this change breaks ABI? Also this change means that there is always be only one SMMU per system. Is that guaranteed too? Regards, Joerg