On Wed, Jun 30, 2021 at 01:56:43PM +0100, Jon Hunter wrote:
> The Tegra serial driver always prints an error message when enabling the
> FIFO for devices that have support for checking the FIFO enable status.
> Fix this by displaying the error message, only when an error occurs.
>
> Finally, update the error message to make it clear that enabling the
> FIFO failed and display the error code.
[...]
> @@ -1045,9 +1045,11 @@ static int tegra_uart_hw_init(struct tegra_uart_port *tup)
>
> if (tup->cdata->fifo_mode_enable_status) {
> ret = tegra_uart_wait_fifo_mode_enabled(tup);
> - dev_err(tup->uport.dev, "FIFO mode not enabled\n");
> - if (ret < 0)
> + if (ret < 0) {
> + dev_err(tup->uport.dev,
> + "Failed to enable FIFO mode: %d\n", ret);
Could you change this to use %pe and ERR_PTR(ret)?
Best Regards
Michał Mirosław
