Le 06/07/2021 à 00:31, Krzysztof Wilczyński a écrit :
Hi Christophe,
Thank you for sending the patches over and taking care about these!
I was wondering whether you will be willing to send a v2 of this series
that would include fixes to everything the checkpatch.pl script reports
against this driver? There aren't a lot of things to fix, thus the idea
to squash everything at once. These warnings would be as follows
(excluding the ones you taken care of in this series):
drivers/pci/controller/pci-tegra.c:1661: WARNING: please, no space before tabs
drivers/pci/controller/pci-tegra.c:1890: WARNING: quoted string split across lines
drivers/pci/controller/pci-tegra.c:1891: WARNING: quoted string split across lines
drivers/pci/controller/pci-tegra.c:2619: WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
These should be trivial to fix. The two pertaining to "quoted string
split across lines" would be something that we might or might not decide
to do anything about this - technically, as per the Linux kernel coding
style [1], we ought to fix this... but, this particular case is not
a terrible example, so I will leave this at your discretion.
What do you think?
Hi,
I don't think it worth it.
Even for patch 2/3 about 'seq_printf' --> 'seq_puts' conversion, I'm not
fully convinced myself that is useful.
Too trivial clean-ups only mess-up 'git blame' for no real added value.
If you want these clean-ups, I can send a patch for it, but checkpatch
output need sometimes to be ignored on files already in the tree. At
least, this is my point of view.
CJ
Also, don't worry if you don't have the time or otherwise, as these are
trivial things and it would only be a bonus to take care of them.
1. https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings
Krzysztof
