On 6/9/2021 3:53 PM, Jon Hunter wrote:
On 08/06/2021 21:11, Jon Hunter wrote:
...
Furthermore, I wonder if we should just move the code
that is required for ACPI into it's own file like
drivers/pci/controller/dwc/pcie-tegra194-acpi.c?
I have been doing some testing and the above works fine. IMO moving the
ACPI specific code to its own file is a lot cleaner and simplifies the
Makefile and Kconfig. Especially seeing as the ACPI quirk code is
independent of the actual Tegra194 PCIe driver. Therefore, unless you
have any objections I will send a patch to fix this by doing just that
tomorrow. Also let me know if you have any concerns about the file name
or location drivers/pci/controller/dwc/pcie-tegra194-acpi.c.
I'm fine with this. No concerns from my side.
That will at least fix the issue with v5.13. If we do that, then for
v5.14 I will clean-up the Kconfig and place everything under a single
CONFIG_PCIE_TEGRA194 entry (which I can send out once the initial
problem is fixed). And finally I will remove the unnecessary cast in the
probe function.
How are we going to address the dependency issues (w.r.t RP and EP) if
we keep only CONFIG_PCIE_TEGRA194?
Jon
