On 09/06/2021 13:58, Dmitry Osipenko wrote: > 09.06.2021 14:28, Thierry Reding пишет: >> From: Thierry Reding <treding@xxxxxxxxxx> >> >> When enabling the COMPILE_TEST Kconfig option, the Tegra memory >> controller can be built without ARCH_TEGRA being selected. However, the >> driver implicitly depends on some symbols pulled in via ARCH_TEGRA, >> which causes the build to break. >> >> Add explicit dependencies for OF_EARLY_FLATTREE and OF_RESERVED_MEM to >> the Tegra MC Kconfig option to make sure they are selected even if >> ARCH_TEGRA is not. >> >> Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> >> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> >> --- >> drivers/memory/tegra/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/memory/tegra/Kconfig b/drivers/memory/tegra/Kconfig >> index f9bae36c03a3..ecfb071fc4f4 100644 >> --- a/drivers/memory/tegra/Kconfig >> +++ b/drivers/memory/tegra/Kconfig >> @@ -48,6 +48,8 @@ config TEGRA124_EMC >> config TEGRA210_EMC_TABLE >> bool >> depends on ARCH_TEGRA_210_SOC || COMPILE_TEST >> + select OF_EARLY_FLATTREE >> + select OF_RESERVED_MEM >> >> config TEGRA210_EMC >> tristate "NVIDIA Tegra210 External Memory Controller driver" >> > > Will this work if CONFIG_OF is disabled? Yeah, good question. That's why I propose "depends on". No issues with unmet or circular dependencies. Best regards, Krzysztof
