Re: [PATCH v6 01/14] gpu: host1x: Add DMA fence implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mikko,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tegra-drm/drm/tegra/for-next]
[also build test WARNING on v5.13-rc3 next-20210528]
[cannot apply to tegra/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mikko-Perttunen/TegraDRM-UAPI/20210530-205239
base:   git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next
config: arm-randconfig-r015-20210530 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project bc6799f2f79f0ae87e9f1ebf9d25ba799fbd25a9)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/5de49ce9211cbf0fbbfeb200e72ce934f4574d4b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mikko-Perttunen/TegraDRM-UAPI/20210530-205239
        git checkout 5de49ce9211cbf0fbbfeb200e72ce934f4574d4b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/gpu/host1x/fence.c:170:5: warning: no previous prototype for function 'host1x_fence_create_fd' [-Wmissing-prototypes]
   int host1x_fence_create_fd(struct host1x_syncpt *sp, u32 threshold)
       ^
   drivers/gpu/host1x/fence.c:170:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int host1x_fence_create_fd(struct host1x_syncpt *sp, u32 threshold)
   ^
   static 
   1 warning generated.


vim +/host1x_fence_create_fd +170 drivers/gpu/host1x/fence.c

   169	
 > 170	int host1x_fence_create_fd(struct host1x_syncpt *sp, u32 threshold)
   171	{
   172		struct sync_file *file;
   173		struct dma_fence *f;
   174		int fd;
   175	
   176		f = host1x_fence_create(sp, threshold);
   177		if (IS_ERR(f))
   178			return PTR_ERR(f);
   179	
   180		fd = get_unused_fd_flags(O_CLOEXEC);
   181		if (fd < 0) {
   182			dma_fence_put(f);
   183			return fd;
   184		}
   185	
   186		file = sync_file_create(f);
   187		dma_fence_put(f);
   188		if (!file)
   189			return -ENOMEM;
   190	
   191		fd_install(fd, file->file);
   192	
   193		return fd;
   194	}
   195	EXPORT_SYMBOL(host1x_fence_create_fd);
   196	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux