Re: [RESEND PATCH V1 4/5] PCI: tegra: Don't allow suspend when Tegra PCIe is in EP mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Prakash

[...]
> @@ -2276,6 +2276,11 @@ static int tegra_pcie_dw_suspend_late(struct device *dev)
[...]
> +	if (pcie->mode == DW_PCIE_EP_TYPE) {
> +		dev_err(dev, "Tegra PCIe is in EP mode, suspend not allowed");
> +		return -EPERM;
> +	}

Would the -EINVAL be more appropriate here?  It seem more appropriate
when something is an invalid operation, rather than access to the
resource being denied (or something along these lines), what do you
think?

	Krzysztof



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux