On 20/04/2021 18:52, Thierry Reding wrote: > From: Thierry Reding <treding@xxxxxxxxxx> > > The current per-SoC setup code runs at a fairly arbitrary point during > probe, thereby making it less flexible for other SoC generations. Move > the call around slightly, which will allow it to be used for other > implementations. You moved from one arbitrary point to another - please therefore explain the rationale of new arbitrary point a little bit more (e.g. after clock initialization? before HW access?) and put it next to struct tegra_mc_ops. Best regards, Krzysztof