20.04.2021 19:52, Thierry Reding пишет:
> +/*
> + * XXX The Tegra186 memory controller driver used to be able to do this. Once
> + * removing the driver is supported on all chips, this can be uncommented.
> + */
> +/*
> +static int tegra_mc_remove(struct platform_device *pdev)
> +{
> + struct tegra_mc *mc = platform_get_drvdata(pdev);
> +
> + if (mc->soc->ops && mc->soc->ops->remove)
> + mc->soc->ops->remove(mc);
> +
> + return 0;
> +}
> +*/
> +
> static int __maybe_unused tegra_mc_suspend(struct device *dev)
> {
> struct tegra_mc *mc = dev_get_drvdata(dev);
> @@ -834,6 +856,9 @@ static struct platform_driver tegra_mc_driver = {
> },
> .prevent_deferred_probe = true,
> .probe = tegra_mc_probe,
> + /*
> + .remove = tegra_mc_remove,
> + */
> };
The commented lines shouldn't be in the final version of the patch, IMO.
These lines either should be uncommented and the remove() callback
should return -EOPNOTSUPP or they should be removed for now.
The rest of the patches look good to me for now, I'll take another look
after testing the patches. Thank you.
