Hi Marc, On 30/03/2021 16:11, Marc Zyngier wrote: > In anticipation of the removal of the msi_controller structure, convert > the Tegra host controller driver to MSI domains. > > We end-up with the usual two domain structure, the top one being a > generic PCI/MSI domain, the bottom one being Tegra-specific and handling > the actual HW interrupt allocation. > > While at it, convert the normal interrupt handler to a chained handler, > handle the controller's MSI IRQ edge triggered, support multiple MSIs > per device and use the AFI_MSI_EN_VEC* registers to provide MSI masking. > > Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > [treding@xxxxxxxxxx: fix, clean up and address TODOs from Marc's draft] > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> > Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx> This change is breaking a suspend test that we are running on Tegra124 Jetson-TK1. The Tegra124 Jetson TK1 uses a PCI based ethernet device ... $ lspci 00:02.0 PCI bridge: NVIDIA Corporation TegraK1 PCIe x1 Bridge (rev a1) 01:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 0c) After resuming from suspend, networking is no longer working. The reason why this breaks our suspend test is because that setup is using NFS for the rootfs. I am looking into it, but if anyone has any thoughts please let me know. Jon -- nvpublic
