On Fri, Mar 26, 2021 at 06:46:40PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
>
> In order to support early console support with the Tegra TCU, add an
> optional "reg" property that points to the TX mailbox.
This will mean the same address in in DT twice which we try to avoid,
right? I guess it's fine, we could drop it if we ever enforce that. I'm
sure there's worse abuses with duplicates than this.
>
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> ---
> .../devicetree/bindings/serial/nvidia,tegra194-tcu.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.yaml b/Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.yaml
> index 0a321658ccb5..8c9ed7cfaa52 100644
> --- a/Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.yaml
> +++ b/Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.yaml
> @@ -24,6 +24,9 @@ properties:
> compatible:
> const: nvidia,tegra194-tcu
>
> + reg:
> + maxItems: 1
> +
> mbox-names:
> items:
> - const: rx
> @@ -48,8 +51,9 @@ examples:
> - |
> #include <dt-bindings/mailbox/tegra186-hsp.h>
>
> - tcu: tcu {
> + tcu: tcu@c168000 {
While you're here:
serial@...
> compatible = "nvidia,tegra194-tcu";
> + reg = <0x0c168000 0x4>;
> mboxes = <&hsp_top0 TEGRA_HSP_MBOX_TYPE_SM 0>,
> <&hsp_aon TEGRA_HSP_MBOX_TYPE_SM 1>;
> mbox-names = "rx", "tx";
> --
> 2.30.2
>
