11.03.2021 20:06, Dmitry Osipenko пишет: > +static const char * const tegra_plane_icc_names[TEGRA_DC_LEGACY_PLANES_NUM] = { > + "wina", "winb", "winc", "", "", "", "cursor", > +}; > + > +int tegra_plane_interconnect_init(struct tegra_plane *plane) > +{ > + const char *icc_name = tegra_plane_icc_names[plane->index]; > + struct device *dev = plane->dc->dev; > + struct tegra_dc *dc = plane->dc; > + int err; > + > + if (WARN_ON(plane->index >= TEGRA_DC_LEGACY_PLANES_NUM) || > + WARN_ON(!tegra_plane_icc_names[plane->index])) > + return -EINVAL; It just occurred to me that I added the NULL-check here, but missed to change "" to NULLs. I'll make a v15 shortly.