Re: [PATCH 3/3] drm/tegra: Add NVDEC driver

[kernel test robot <lkp@xxxxxxxxx>]

Hi Mikko,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tegra/for-next]
[also build test ERROR on robh/for-next tegra-drm/drm/tegra/for-next v5.11-rc7 next-20210212]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mikko-Perttunen/NVIDIA-Tegra-NVDEC-support/20210213-181808
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/5951327b2039bedd20ca3e7837d4cb6021dc9777
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mikko-Perttunen/NVIDIA-Tegra-NVDEC-support/20210213-181808
        git checkout 5951327b2039bedd20ca3e7837d4cb6021dc9777
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/tegra/nvdec.c: In function 'nvdec_init':
>> drivers/gpu/drm/tegra/nvdec.c:131:2: error: implicit declaration of function 'host1x_syncpt_put'; did you mean 'host1x_syncpt_get'? [-Werror=implicit-function-declaration]
     131 |  host1x_syncpt_put(client->syncpts[0]);
         |  ^~~~~~~~~~~~~~~~~
         |  host1x_syncpt_get
   cc1: some warnings being treated as errors


vim +131 drivers/gpu/drm/tegra/nvdec.c

    91	
    92	static int nvdec_init(struct host1x_client *client)
    93	{
    94		struct tegra_drm_client *drm = host1x_to_drm_client(client);
    95		struct drm_device *dev = dev_get_drvdata(client->host);
    96		struct tegra_drm *tegra = dev->dev_private;
    97		struct nvdec *nvdec = to_vic(drm);
    98		int err;
    99	
   100		err = host1x_client_iommu_attach(client);
   101		if (err < 0 && err != -ENODEV) {
   102			dev_err(nvdec->dev, "failed to attach to domain: %d\n", err);
   103			return err;
   104		}
   105	
   106		nvdec->channel = host1x_channel_request(client);
   107		if (!nvdec->channel) {
   108			err = -ENOMEM;
   109			goto detach;
   110		}
   111	
   112		client->syncpts[0] = host1x_syncpt_request(client, 0);
   113		if (!client->syncpts[0]) {
   114			err = -ENOMEM;
   115			goto free_channel;
   116		}
   117	
   118		err = tegra_drm_register_client(tegra, drm);
   119		if (err < 0)
   120			goto free_syncpt;
   121	
   122		/*
   123		 * Inherit the DMA parameters (such as maximum segment size) from the
   124		 * parent host1x device.
   125		 */
   126		client->dev->dma_parms = client->host->dma_parms;
   127	
   128		return 0;
   129	
   130	free_syncpt:
 > 131		host1x_syncpt_put(client->syncpts[0]);
   132	free_channel:
   133		host1x_channel_put(nvdec->channel);
   134	detach:
   135		host1x_client_iommu_detach(client);
   136	
   137		return err;
   138	}
   139	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip