Re: [PATCH v2 3/9] ASoC: audio-graph-card: Add clocks property to endpoint node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2/5/2021 8:56 PM, Rob Herring wrote:
External email: Use caution opening links or attachments


On Fri, Jan 29, 2021 at 11:57:40PM +0530, Sameer Pujar wrote:
Add optional 'clocks' property to audio port 'endpoint' node. One
such example is where SoC supplies a clock to external audio codec
component.

Signed-off-by: Sameer Pujar <spujar@xxxxxxxxxx>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
Reviewed-by: Jon Hunter <jonathanh@xxxxxxxxxx>
---
  Documentation/devicetree/bindings/sound/audio-graph-port.yaml | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
index 766e910..08ed8f5 100644
--- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
+++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
@@ -33,6 +33,9 @@ properties:
          properties:
            remote-endpoint:
              maxItems: 1
+          clocks:
+            maxItems: 1
+            description: Describes the clock used by audio component.
NAK

An endpoint is not a device. Clocks go with a device.

I made this change on similar lines with [0]. I am not sure if there are other examples of such usage. If this is not recommended, I will try moving this to device node. Looks like it needs a driver fix in simple-card-utils.c


[0] https://elixir.bootlin.com/linux/v5.11-rc7/source/Documentation/devicetree/bindings/sound/simple-card.yaml#L



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux