Re: [PATCH] clk: tegra: clk-dfll: Verify regulator vsel values are valid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 27, 2021 at 05:11:21PM +0000, Jon Hunter wrote:
> The regulator function, regulator_list_hardware_vsel(), may return an
> negative error code on failure. The Tegra DFLL driver does not check to
> see if the value returned by this function is an error. Fix this by
> updating the DFLL driver to check if the value returned by
> regulator_list_hardware_vsel() is an error and if an error does occur
> propagate the error.
> 
> Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx>
> ---
>  drivers/clk/tegra/clk-dfll.c | 32 ++++++++++++++++++++++++--------
>  1 file changed, 24 insertions(+), 8 deletions(-)

Does this fix any particular issue? Do we want a Fixes: line for this?

In either case, this looks like a correct fix, so:

Acked-by: Thierry Reding <treding@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux