On 18-01-21, 11:59, Ulf Hansson wrote: > Good point! I certainly overlooked that when reviewing. We need to > reevaluate the new state when propagating to the parent(s). > > To me, it looks like when doing the propagation we must check if the > parent has the ->set_performance_state() callback assigned. If so, we > should call dev_pm_opp_xlate_performance_state(), but otherwise just > use the value of "state", when doing the reevaluation. > > Does it make sense? That will work but I am wondering if there is a way to avoid the unnecessary propagation if we can somehow find out if someone above in hierarchy supports pstates or not ? -- viresh