14.01.2021 16:47, Lee Jones пишет: > On Mon, 28 Dec 2020, Dmitry Osipenko wrote: > >> Acer Iconia Tab A500 is an Android tablet device, it has ENE KB930 >> Embedded Controller which provides battery-gauge, LED, GPIO and some >> other functions. The EC uses firmware that is specifically customized >> for Acer A500. This patch adds MFD driver for the Embedded Controller >> which allows to power-off / reboot the A500 device, it also provides >> a common register read/write API that will be used by the sub-devices. >> >> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx> >> --- >> drivers/mfd/Kconfig | 11 ++ >> drivers/mfd/Makefile | 1 + >> drivers/mfd/acer-ec-a500.c | 202 +++++++++++++++++++++++++++++++++++++ >> 3 files changed, 214 insertions(+) >> create mode 100644 drivers/mfd/acer-ec-a500.c > > Looks good to me: > > For my own reference (apply this as-is to your sign-off block): > > Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx> > > Do you have a merge plan? > Thanks, you could take the DT binding and the MFD patches into the MFD tree right now. Perhaps will be better to merge the battery patch via the Power tree since it doesn't have build dependency on the MFD patch. The battery patch was reviewed by Sebastian, but not acked, as I see now. Sebastian, could you please take the battery patch?